[vfs_rework] Do not forcibly focus to just refreshed listpanel
AbandonedPublic

Authored by martinkostolny on Nov 16 2016, 11:08 PM.

Details

Reviewers
None
Group Reviewers
Krusader
Summary

When a remote location connection is slow, it can take some time to refresh a remote directory. While refreshing, one can freely browse another directory in other panel. But when refreshing directory is finished, related panel is forcibly focused.

This patch prevents that.

Test Plan
  1. open new tab in left panel
  2. fire up e.g. a slow remote location url
  3. switch to right panel before requested location was loaded
  4. when left panel is refreshed, check that right panel preserved its focus

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinkostolny retitled this revision from to [vfs_rework] Do not forcibly focus to just refreshed listpanel.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
martinkostolny added a project: Krusader.
abika added a subscriber: abika.Nov 20 2016, 8:29 PM

Thanks for finding the cause! But because it is caused by the search bar it should be fixed by the search bar imo.
I already pushed a fix to master.

And sorry that I wrote the code. The design is actually wrong: The search bar should already be closed before the refresh is started. And the right place for this is PanelFunc::doRefresh() which also needs some cleanup. But this belongs to another track I will eventually work on some time later...

asensi added a subscriber: asensi.Nov 20 2016, 10:20 PM

And sorry that I wrote the code.

Alex, your work is bigger than that, taking everything into account... people have a lot to thank to you :-)

people have a lot to thank to you :-)

Exactly. Thanks for doing it the right way! :)

martinkostolny abandoned this revision.Nov 20 2016, 11:39 PM
abika added a comment.Nov 21 2016, 5:20 PM

Thanks guys! Its always a big motivation to hear some nice words:)