Differential D3381

Move defaultOpenAction setting to the new General settings page
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 16 2016, 12:22 PM.

Details

Reviewers
rthomsen
Commits
R36:5e3906ccf56d: Move defaultOpenAction to General Settings page
Summary

This setting is about the default double-click behavior, so does not really belong to the Preview page.

BUG: 357658
FIXED-IN: 16.12.0

Test Plan

Works

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 8215.Nov 16 2016, 12:22 PM
elvisangelaccio retitled this revision from to Move defaultOpenAction setting to the new General settings page.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
Restricted Application added a project: Ark. · View Herald TranscriptNov 16 2016, 12:22 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen edited edge metadata.Nov 16 2016, 8:30 PM
In D3381#63125, @elvisangelaccio wrote:

The label above the two radio buttons seems to not be left-aligned?

elvisangelaccio updated this revision to Diff 8279.Nov 17 2016, 3:31 PM
elvisangelaccio edited edge metadata.

Fixed label alignment.

rthomsen accepted this revision.Nov 17 2016, 6:17 PM
rthomsen edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 6:17 PM
Closed by commit R36:5e3906ccf56d: Move defaultOpenAction to General Settings page (authored by elvisangelaccio). · Explain WhyNov 17 2016, 6:29 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:5e3906ccf56d: Move defaultOpenAction to General Settings page.

Revision Contents
Changeset List

Diff 8287

View Options

kerfuffle/ark.kcfg

Loading...
View Options

kerfuffle/generalsettings.ui

Loading...
View Options

kerfuffle/previewsettings.ui

Loading...