Add setting to disable AES encryption warning
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 16 2016, 12:14 PM.

Details

Reviewers

Commits

R36:1caeff2b888d: Add option to disable AES encryption warning

Summary

See title. A new General settings page is added to the settings dialog. For now there is
only the new checkbox, but this page will also be used for the radiobuttons
currently in the Preview page (see bug #357658).

Test Plan

Create a zip with AES encryption with/without the new option checked.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 8214.Nov 16 2016, 12:14 PM

elvisangelaccio retitled this revision from to Add setting to disable AES encryption warning.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptNov 16 2016, 12:14 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

elvisangelaccio added a dependent revision: D3381: Move defaultOpenAction setting to the new General settings page.Nov 16 2016, 12:22 PM

The icon for the General Settings page looks a bit out of place, but I don't know which icon to use instead.

Fix it then ship it! :)

kerfuffle/generalsettings.ui
18	Remove the period at the end of the sentence.

This revision is now accepted and ready to land.Nov 16 2016, 8:21 PM

What about the applications-system icon?

In D3380#63299, @rthomsen wrote:

What about the applications-system icon?

Also looks out of place imho... What about go-home like Kate does?

In D3380#63442, @elvisangelaccio wrote:

In D3380#63299, @rthomsen wrote:

What about the applications-system icon?

Also looks out of place imho... What about go-home like Kate does?

Yes, much better :)

Closed by commit R36:1caeff2b888d: Add option to disable AES encryption warning (authored by elvisangelaccio). · Explain WhyNov 17 2016, 3:20 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:1caeff2b888d: Add option to disable AES encryption warning.

Revision Contents
Changeset List

		Path
M		kerfuffle/CMakeLists.txt (2 lines)
M		kerfuffle/ark.kcfg (6 lines)
M		kerfuffle/compressionoptionswidget.cpp (3 lines)
A	M	kerfuffle/generalsettings.ui (41 lines)
A	M	kerfuffle/generalsettingspage.h (45 lines)
A	M	kerfuffle/generalsettingspage.cpp (38 lines)
M		part/part.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8214	9e49ae1		Nov 16 2016, 12:14 PM	★	★
Diff 2	8277	9e49ae1	rARK1caeff2b888dbff865bd8c879e21b10f10aec940	Nov 17 2016, 3:08 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4acee42cbf58	6781321150da	36fefa82d66c	Elvis Angelaccio	label++	Nov 16 2016, 12:06 PM
36fefa82d66c	c69b6c3f8bca	f819dc9453a5	Elvis Angelaccio	Use new settings	Nov 15 2016, 6:48 PM
f819dc9453a5	1c50ab80485d	bd4684a2f9f2	Elvis Angelaccio	Add page to dialog	Nov 15 2016, 6:43 PM
bd4684a2f9f2	8c6f8e013967	4a2715a7a38c	Elvis Angelaccio	build new page	Nov 15 2016, 6:40 PM
4a2715a7a38c	648a62aacead	9e49ae1e14cf	Elvis Angelaccio	new setting in kfcg	Nov 15 2016, 6:33 PM

	Status	Author	Revision
	Closed	elvisangelaccio	D3381 Move defaultOpenAction setting to the new General settings page
	Closed	elvisangelaccio	D3380 Add setting to disable AES encryption warning