Remove Webkit usage in potd data engine.
ClosedPublic

Authored by xuetianweng on Nov 15 2016, 10:55 PM.

Details

Summary

For natgeoprovider, since the page it can be accepted by QXmlStreamReader
to get required content, we simply parse it as XML though HTML is NOT
necessarily valid XML.

For noaaprovider, QXmlStreamReader will hit an error in the middle of parsing
so we use regular expression to extract the url.

Test Plan

Manually test with plasmashell

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xuetianweng retitled this revision from to Remove Webkit usage in potd data engine..
xuetianweng updated this object.
xuetianweng edited the test plan for this revision. (Show Details)
xuetianweng added reviewers: mart, hein, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2016, 10:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Nov 16 2016, 9:48 AM
broulik edited edge metadata.

Thanks a lot for taking care of this so quickly!

I can confirm that both NOAA and NatGeo still work with this change.

This revision is now accepted and ready to land.Nov 16 2016, 9:48 AM
xuetianweng updated this object.Nov 16 2016, 5:13 PM
xuetianweng edited edge metadata.
xuetianweng updated this object.
xuetianweng closed this revision.Nov 16 2016, 5:14 PM