import kbookmarkmerger manpage from kde-baseapps + update to kf5
ClosedPublic

Authored by lueck on Nov 11 2016, 3:31 PM.

Details

Summary

imported from kde-baseapps to get the history with git log follow, this did not work for me importing from konqueror repo
added to the build
updated to kf5

bump date+releaseinfo
remove Qt Options + KDE Options
add kf5options
no qt5options because this is no gui application

diff to the manpage in konqueror/kde-baseapps see https://paste.kde.org/peye8i3dh

Test Plan

builds

Diff Detail

Repository
R227 KEditBookmarks
Lint
Lint Skipped
Unit
Unit Tests Skipped
lueck updated this revision to Diff 8096.Nov 11 2016, 3:31 PM
lueck retitled this revision from to import kbookmarkmerger manpage from kde-baseapps + update to kf5.
lueck updated this object.
lueck edited the test plan for this revision. (Show Details)
lueck added reviewers: dfaure, Documentation.
lueck set the repository for this revision to R227 KEditBookmarks.
ltoscano added inline comments.
doc/man-kbookmarkmerger.1.docbook
45

This is probably the good time to fix things like "&kde; is running"

lueck added inline comments.Nov 11 2016, 7:33 PM
doc/man-kbookmarkmerger.1.docbook
45

what provides the bookmark subsystem? plasma/workspace?

ltoscano added inline comments.Nov 11 2016, 9:57 PM
doc/man-kbookmarkmerger.1.docbook
45

I'm not sure how it works in the frameworks world, and if there is still a bookmark subsystem. I would say that if no input comes on this point, I would remove or comment the sentence from "In case &kde;" to "... will pick the changes up instanctly." and commit before the freeze.

lueck updated this revision to Diff 8141.Nov 14 2016, 8:25 PM

Commented sentence about bookmark subsystem,

ltoscano accepted this revision.Nov 14 2016, 8:32 PM
ltoscano added a reviewer: ltoscano.
This revision is now accepted and ready to land.Nov 14 2016, 8:32 PM
This revision was automatically updated to reflect the committed changes.
dfaure added inline comments.Nov 20 2016, 8:49 PM
doc/man-kbookmarkmerger.1.docbook
45

The KBookmarks framework provides the bookmark subsystem.

Plasma is not involved at all.

lueck updated this revision to Diff 8571.Nov 28 2016, 3:49 PM
lueck edited edge metadata.

readd info about bookmark subsystem

lueck added a comment.Nov 28 2016, 3:57 PM

update man page