Move resolving glxSwapIntervalMesa into platform plugin
ClosedPublic
Actions

Authored by graesslin on Nov 11 2016, 7:19 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

Summary

No need to resolve glx methods through the shared lib. At the moment
this duplicates some code, but will be cleaned up with a follow up
change.

Test Plan

Tested on X11, function gets resolved and used.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Move resolving glxSwapIntervalMesa into platform plugin.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

bshah added a reviewer: bshah.

This revision is now accepted and ready to land.Nov 16 2016, 6:58 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libkwineffects/kwinglutils.h (3 lines)
M			libkwineffects/kwinglutils.cpp (17 lines)
M			libkwineffects/kwinglutils_funcs.h (6 lines)
M			libkwineffects/kwinglutils_funcs.cpp (11 lines)
M			plugins/platforms/x11/standalone/glxbackend.h (4 lines)
M			plugins/platforms/x11/standalone/glxbackend.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8084	c70546e		Nov 11 2016, 7:19 AM	★	★
Diff 2	8199	4783e45	rKWINfeac312ee02039de2fa5f372d595612a3d17600d	Nov 16 2016, 8:06 AM	★	★

Status	Author	Revision
Closed	graesslin	D3337 Remove KWin::display from kwinglobals
Closed	graesslin	D3336 Pass function ptr to resolve glFunctions to initGL
Closed	graesslin	D3335 Move resolving glxSwapIntervalMesa into platform plugin
Closed	graesslin	D3332 Move querying glx extensions into the platform plugin
Closed	graesslin	D3329 Move glx version check functionality to platform plugin