Make it possible for plasmashell to log into kscreen.log
AbandonedPublic

Authored by sebas on Nov 9 2016, 11:40 PM.

Details

Reviewers
mart
Summary
  • install message handler that writes debug messages in the kscreen.* categories and track outputs
  • add KSCREEN_PLASMASHELL debug category
  • debugging for output changes, pretty basic, maybe we want to add some
Test Plan

tested if these things now end up in kscreen.log, they do

Diff Detail

Repository
R120 Plasma Workspace
Branch
sebas/kscreenlog
Lint
No Linters Available
Unit
No Unit Test Coverage
sebas updated this revision to Diff 8056.Nov 9 2016, 11:40 PM
sebas retitled this revision from to Make it possible for plasmashell to log into kscreen.log.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: mart.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 9 2016, 11:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added inline comments.
shell/shellcorona.cpp
87

static

95

Just saying: I don't like this writing to a dedicated file per session. We are starting to introduce a second xsession-errors.

Also I don't like that we have a duplication for the log message handling here between kscreen and plasma-workspace. If we want to start having additional applications write to the kscreen log, libkscreen should expose an API for it.

I also have to ask why debug messages like "plasmashell starting" should go into a "kscreen.log". How is that in any way related to kscreen? This is semantically not correct. I understand that you want everything multi screen related in one log file, but then please get the semantics correct.

125

this is not screen related

sebas abandoned this revision.Nov 10 2016, 10:21 AM

We may already have fixed the most pressing problem needing this, so postponing/abandoning it for now.

cfeck added a subscriber: cfeck.Nov 10 2016, 11:17 AM

Sorry, my fault. I was completely unaware that Plasma does not even use kscreen. Now that I have seen how it works, I am no longer disappointed to not find Plasma steps in the kscreen logs.