Remove implicit sharing from GeoDataFeature & subclasses
ClosedPublic
Actions

Authored by kossebau on Nov 9 2016, 6:45 AM.

Details

Reviewers

nienhueser
rahn

Group Reviewers

Marble

Commits

R34:7bcd0676d285: Remove implicit sharing from GeoDataFeature & subclasses

Summary

Also integrate pimpl classes of more subclasses by subclassing from
GeoDataFeaturePrivate

Implict sharing conflicts with parentship properties on members of
some subclasses

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 8036.Nov 9 2016, 6:45 AM

kossebau retitled this revision from to Remove implicit sharing from GeoDataFeature & subclasses.

kossebau updated this object.

kossebau added reviewers: Marble, nienhueser, rahn.

Looks good to me in general :) I trust you on the details :)

This revision is now accepted and ready to land.Nov 10 2016, 4:11 PM

Closed by commit R34:7bcd0676d285: Remove implicit sharing from GeoDataFeature & subclasses (authored by kossebau). · Explain WhyNov 10 2016, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/lib/marble/geodata/data/GeoDataChange.h (6 lines)
M		src/lib/marble/geodata/data/GeoDataChange.cpp (30 lines)
M		src/lib/marble/geodata/data/GeoDataContainer.h (6 lines)
M		src/lib/marble/geodata/data/GeoDataContainer.cpp (66 lines)
M		src/lib/marble/geodata/data/GeoDataContainer_p.h (27 lines)
M		src/lib/marble/geodata/data/GeoDataCreate.h (6 lines)
M		src/lib/marble/geodata/data/GeoDataCreate.cpp (30 lines)
M		src/lib/marble/geodata/data/GeoDataDelete.h (6 lines)
M		src/lib/marble/geodata/data/GeoDataDelete.cpp (30 lines)
M		src/lib/marble/geodata/data/GeoDataDocument.h (4 lines)
M		src/lib/marble/geodata/data/GeoDataDocument.cpp (49 lines)
M		src/lib/marble/geodata/data/GeoDataDocument_p.h (18 lines)
M		src/lib/marble/geodata/data/GeoDataFeature.h (9 lines)
M		src/lib/marble/geodata/data/GeoDataFeature.cpp (112 lines)
M		src/lib/marble/geodata/data/GeoDataFeature_p.h (16 lines)
M		src/lib/marble/geodata/data/GeoDataFolder.h (4 lines)
M		src/lib/marble/geodata/data/GeoDataFolder.cpp (28 lines)
M		src/lib/marble/geodata/data/GeoDataGroundOverlay.h (11 lines)
M		src/lib/marble/geodata/data/GeoDataGroundOverlay.cpp (70 lines)
A	M	src/lib/marble/geodata/data/GeoDataGroundOverlay_p.h (43 lines)
M		src/lib/marble/geodata/data/GeoDataNetworkLink.h (2 lines)
M		src/lib/marble/geodata/data/GeoDataNetworkLink.cpp (6 lines)
M		src/lib/marble/geodata/data/GeoDataNetworkLinkControl.h (6 lines)
M		src/lib/marble/geodata/data/GeoDataNetworkLinkControl.cpp (133 lines)
A	M	src/lib/marble/geodata/data/GeoDataNetworkLinkControl_p.h (97 lines)
M		src/lib/marble/geodata/data/GeoDataOverlay.h (11 lines)
M		src/lib/marble/geodata/data/GeoDataOverlay.cpp (68 lines)
A	M	src/lib/marble/geodata/data/GeoDataOverlay_p.h (48 lines)
M		src/lib/marble/geodata/data/GeoDataPhotoOverlay.h (7 lines)
M		src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp (70 lines)
A	M	src/lib/marble/geodata/data/GeoDataPhotoOverlay_p.h (58 lines)
M		src/lib/marble/geodata/data/GeoDataPlacemark.h (2 lines)
M		src/lib/marble/geodata/data/GeoDataPlacemark.cpp (75 lines)
M		src/lib/marble/geodata/data/GeoDataPlacemark_p.h (91 lines)
M		src/lib/marble/geodata/data/GeoDataScreenOverlay.h (7 lines)
M		src/lib/marble/geodata/data/GeoDataScreenOverlay.cpp (61 lines)
A	M	src/lib/marble/geodata/data/GeoDataScreenOverlay_p.h (37 lines)
M		src/lib/marble/geodata/data/GeoDataTour.h (5 lines)
M		src/lib/marble/geodata/data/GeoDataTour.cpp (26 lines)
M		src/lib/marble/geodata/data/GeoDataTour_p.h (15 lines)
M		tests/TestGeoDataCopy.cpp (5 lines)