Differential D3314

Properly test environment variable
ClosedPublic
Actions

Authored by apol on Nov 8 2016, 11:56 PM.

Details

Reviewers
sitter
sebas
Group Reviewers
Frameworks
Commits
R237:49203c61c7b6: Properly test environment variable
Summary

use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 8034.Nov 8 2016, 11:56 PM
apol retitled this revision from to Properly test environment variable.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Frameworks.
sebas accepted this revision.Nov 17 2016, 11:24 AM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Nov 17 2016, 11:24 AM
apol updated this revision to Diff 8256.Nov 17 2016, 11:26 AM
apol edited edge metadata.

Use qEnvironmentVariableIsEmpty so we don't change the behaviour

sitter accepted this revision.Nov 17 2016, 11:27 AM
sitter added a reviewer: sitter.
apol closed this revision.Nov 17 2016, 11:28 AM

Revision Contents
Changeset List

PathPackages
Msrc/core/ksharedconfig.cpp (4 lines)

Diff 8256

View Options

src/core/ksharedconfig.cpp

Loading...