Differential D3249

Use our tooling for installing plasmoids
ClosedPublic
Actions

Authored by apol on Nov 3 2016, 1:53 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R114:96211d07b193: Use our tooling for installing plasmoids
Summary

use kpackage/plasma macros to install the files. This way we get all
the features provided by the macro.

Test Plan

didn't find regressions

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 7862.Nov 3 2016, 1:53 PM
apol retitled this revision from to Use our tooling for installing plasmoids.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Plasma, mart.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 3 2016, 1:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 4 2016, 10:15 AM
mart edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 10:15 AM
Closed by commit R114:96211d07b193: Use our tooling for installing plasmoids (authored by apol). · Explain WhyNov 4 2016, 11:26 AM
This revision was automatically updated to reflect the committed changes.
lbeltrame added a subscriber: lbeltrame.EditedNov 5 2016, 8:20 AM

kdeplasma-addons doesn't build here with these changes:

[  201s] [  1%] Generating konsoleprofiles/package-metadata.json
[  201s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~96211d0/build'
[  201s] cd "/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~96211d0/build/applets" && /usr/bin/desktoptojson -i /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~96211d0/applets/konsoleprofiles/package/metadata.desktop -o /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~96211d0/build/applets/konsoleprofiles/package-metadata.json
[  201s] Error: Failed to open  "/home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.8.90git~20161104T122545~96211d0/build/applets/konsoleprofiles/package-metadata.json" 
[  201s]  ((null):0, (null))
[  201s] Unknown property type for key "X-Plasma-API" -> falling back to string
[  201s] Unknown property type for key "X-Plasma-MainScript" -> falling back to string
[  201s] make[2]: *** [applets/CMakeFiles/org.kde.plasma.konsoleprofiles-metadata-json.dir/build.make:61: applets/konsoleprofiles/package-metadata.json] Error 1
lbeltrame added a comment.Nov 5 2016, 8:25 AM

Forgot to add, cmake complains about not being able to find plugin metadata.

lbeltrame added a comment.EditedNov 5 2016, 8:28 AM

The reason is that CMake doesn't generate the konsoleprofiles directory in the build directory when configuring.

Revision Contents
Changeset List

Diff 7896

View Options

applets/CMakeLists.txt

Loading...
View Options

applets/activitypager/CMakeLists.txt

Loading...
View Options

applets/kickerdash/CMakeLists.txt

Loading...
View Options

applets/konsoleprofiles/CMakeLists.txt

Loading...