[Notification Applet] Position dialog before showing it
AbandonedPublic

Authored by broulik on Oct 30 2016, 10:18 PM.

Details

Reviewers
mck182
mart
Group Reviewers
Plasma
Summary

This ensures the dialog gets a proper position before being shown.

On Wayland notification popups are animated by the morphing popup effect and would fly all over the screen when shown; now they only move around in the vicinity of their final position, looking really nice.

Test Plan

Only tested on Wayland.

With all of X's quirks this overly complex code needs to be tested more. I removed the updateVisibility calls which I don't think are neccessary and it works just fine here but I don't trust X here. Will test on X soon.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 7762.Oct 30 2016, 10:18 PM
broulik retitled this revision from to [Notification Applet] Position dialog before showing it.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 30 2016, 10:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 4 2016, 11:05 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

tested locally on x11, it seems to still work correctly

applets/notifications/plugin/notificationshelper.cpp
150

is the delay by timer still needed?

This revision is now accepted and ready to land.Nov 4 2016, 11:05 AM
mart added inline comments.Jun 12 2017, 2:39 PM
applets/notifications/plugin/notificationshelper.cpp
154

at this point it still thinks the size is 0,0

What's the status of this?

broulik abandoned this revision.Apr 9 2019, 6:47 PM

Likely obsoleted by notification rewrite