Differential D3009

Fix logout translation message
ClosedPublic
Actions

Authored by guoyunhe on Oct 10 2016, 3:57 PM.

Details

Reviewers
mart
Group Reviewers
Plasma: Workspaces
Summary

The setText() function should accept readable text, not command. Just like other actions.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
guoyunhe updated this revision to Diff 7268.Oct 10 2016, 3:57 PM
guoyunhe retitled this revision from to Fix logout translation message.
guoyunhe updated this object.
guoyunhe edited the test plan for this revision. (Show Details)
guoyunhe added a reviewer: Plasma: Workspaces.
guoyunhe set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2016, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe updated this revision to Diff 7272.Oct 10 2016, 4:13 PM
guoyunhe removed R120 Plasma Workspace as the repository for this revision.

Comparing commands should add context "log out command". This might be a copy-paste mistake. However, is it necessary to translate a command? Because it might be translated to anything by i18n teams, so the comparsion result is unpredictable.

mart accepted this revision.Oct 10 2016, 4:18 PM
mart added a reviewer: mart.
mart added a subscriber: mart.

yes, it's fine that the command is translated

This revision is now accepted and ready to land.Oct 10 2016, 4:18 PM
davidedmundson added a subscriber: davidedmundson.Oct 17 2016, 7:51 AM

Do you have commit access?

guoyunhe added a comment.Oct 17 2016, 8:41 AM
In D3009#57056, @davidedmundson wrote:

Do you have commit access?

No, I do not have.

guoyunhe closed this revision.Feb 7 2017, 12:49 PM

Revision Contents
Changeset List

PathPackages
Mrunners/sessions/sessionrunner.cpp (6 lines)

Diff 7272

View Options

runners/sessions/sessionrunner.cpp

Loading...