Correctly determine endianness on the specific platform using `endian.h' header available at least on GCC. Must be verified for other platforms and compilers.
Details
Details
Diff Detail
Diff Detail
- Repository
- R311 KWallet
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
This stack overflow answer has a more exhaustive approach to determining endianness. It may be worth extracting this code into a more appropriate header file though. Also here's the issue on the bugzilla tracker
Comment Actions
Thanks for the patch! FWIW we have moved patch review to GitLab; consider abandoning this and re-submitting it as a merge request at https://invent.kde.org/frameworks/kwallet/-/merge_requests
Here's some documentation: https://community.kde.org/Infrastructure/GitLab
Comment Actions
Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite a mission getting everyone over to new platforms ๐ ๐