Thumbnail folders: scale down sub image when their height is too big
AbandonedPublic

Authored by meven on May 17 2020, 6:25 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Summary

BUG: 419566
FIXED-IN: 20.08

Test Plan

Before:

After

Diff Detail

Repository
R320 KIO Extras
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27004
Build 27022: arc lint + arc unit
meven created this revision.May 17 2020, 6:25 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMay 17 2020, 6:25 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.May 17 2020, 6:25 AM
meven edited the test plan for this revision. (Show Details)May 17 2020, 6:26 AM

Haha the "before" image is hilarious!

thumbnail/thumbnail.cpp
415

Is this an else if (...) { or an else { if (...) {

meven planned changes to this revision.May 18 2020, 4:22 PM

Will probably send to gitlab ;)