[kcm/kwinrules] Fix placeholder message in RulesEditor
ClosedPublic

Authored by iasensio on Fri, May 15, 4:40 PM.

Details

Summary

Fix the anchoring of the placeholder message after https://phabricator.kde.org/R108:9e5498238f88ece28f4f0d22da00879280cb7955
It needs to center on the free space, not the whole ListView.

Test Plan
Before:


After:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Fri, May 15, 4:40 PM
Restricted Application added a project: KWin. · View Herald TranscriptFri, May 15, 4:40 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
iasensio requested review of this revision.Fri, May 15, 4:40 PM
ngraham accepted this revision.Fri, May 15, 4:51 PM

The problem with setting both top and bottom anchors (or using anchors.fill) is that it stretches the component and distorts the spacing between its internal items. However this instance doesn't have multiple items, so it's fine. However please add a comment mentioning this, should someone ever add a text label or an icon in the future.

Probably safe for landing on 5.19.

This revision is now accepted and ready to land.Fri, May 15, 4:51 PM
iasensio updated this revision to Diff 82967.Fri, May 15, 5:27 PM
  • Add comment
ngraham accepted this revision.Fri, May 15, 5:51 PM
This revision was automatically updated to reflect the committed changes.