Differential D29783

[kcm/kwinrules] Fix placeholder message in RulesEditor
ClosedPublic
Actions

Authored by iasensio on May 15 2020, 4:40 PM.

Details

Reviewers
ngraham
broulik
Group Reviewers
VDG
Plasma
Commits
R108:973957127dd4: [kcm/kwinrules] Fix placeholder message in RulesEditor
Summary

Fix the anchoring of the placeholder message after https://phabricator.kde.org/R108:9e5498238f88ece28f4f0d22da00879280cb7955
It needs to center on the free space, not the whole ListView.

Test Plan
Before:


After:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.May 15 2020, 4:40 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 15 2020, 4:40 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
iasensio requested review of this revision.May 15 2020, 4:40 PM
ngraham accepted this revision.May 15 2020, 4:51 PM

The problem with setting both top and bottom anchors (or using anchors.fill) is that it stretches the component and distorts the spacing between its internal items. However this instance doesn't have multiple items, so it's fine. However please add a comment mentioning this, should someone ever add a text label or an icon in the future.

Probably safe for landing on 5.19.

This revision is now accepted and ready to land.May 15 2020, 4:51 PM
iasensio updated this revision to Diff 82967.May 15 2020, 5:27 PM
  • Add comment
ngraham accepted this revision.May 15 2020, 5:51 PM
Closed by commit R108:973957127dd4: [kcm/kwinrules] Fix placeholder message in RulesEditor (authored by iasensio). · Explain WhyMay 15 2020, 5:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82969

View Options

kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml

Loading...