Differential D29743

sftp: map sftp_open error to kio error
ClosedPublic
Actions

Authored by sitter on May 14 2020, 12:26 PM.

Details

Reviewers
feverfew
Commits
R320:07e44cb1b536: sftp: map sftp_open error to kio error
Summary

sftp gives out more relevant errors such as SSH_FX_PERMISSION_DENIED,
let's forward them as KIO errors instead of using the general cannot open
error.

Test Plan

hoping for the best! bad permissions on the remote now actually raise suitable kio errors, functionally that seems to make little difference unfortunately

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.May 14 2020, 12:26 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMay 14 2020, 12:26 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.May 14 2020, 12:26 PM
feverfew accepted this revision.May 14 2020, 2:11 PM
This revision is now accepted and ready to land.May 14 2020, 2:11 PM
Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error (authored by sitter). · Explain WhyMay 15 2020, 8:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msftp/kio_sftp.cpp (2 lines)

Diff 82903

View Options

sftp/kio_sftp.cpp

Loading...