Everything added except for both trash icons because
I couldn't figure out how to use svg cleaner without
getting rid of the gradient.
BUG:421144
FIXED-IN: 5.71
ngraham | |
ndavis |
VDG |
Everything added except for both trash icons because
I couldn't figure out how to use svg cleaner without
getting rid of the gradient.
BUG:421144
FIXED-IN: 5.71
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I just noticed, the new auto-generated 24px places icons aren't being used because the places/24 folder isn't in the index.theme files, but that's outside the scope of this patch.
No. Phabricator doesn't keep the original context for those comments if you change the code they were referring to. I think GitLab doesn't have that problem.
I have to say, I'm very impressed overall. There are a few things I'd like to see changed though:
folder-documents should use a single page, not the copy icon
I suppose they should all have the corner at the top right, but that can be done another time.folder-network is using a different style
folder-scripts is using a different style
panel elements in user-desktop should be more like the 32px version
The 64px version should be changed too, but that can be done another time.folder-games inner symbol looks a bit small, but that's going to be extra work, so I won't fault you if you'd rather do that later. The 16px version that you reused for the 48px symbol is a bit too small at 16px anyway, so that can be done another time.
Interestingly, document-print uses a different style for the smallest printer icon size. I think I prefer the document-print version, but that change can be done another time.