OverlaySheet has a header: property typically used to give the sheet a title. This patch
used it to give all of Discover's OverlaySheets appropriate titles. The review sheet's
top layout is slightly adjusted to make this look good.
Details
Details
- Reviewers
apol leinir - Group Reviewers
Discover Software Store VDG - Commits
- R134:fb1880d436a8: Give all OverlaySheets consistent headers
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26837 Build 26855: arc lint + arc unit
Comment Actions
We are in string freeze right now, aren't we?
discover/qml/ApplicationPage.qml | ||
---|---|---|
282 ↗ | (On Diff #82734) | I guess this was for testing? |
Comment Actions
String freeze is tomorrow.
discover/qml/ApplicationPage.qml | ||
---|---|---|
282 ↗ | (On Diff #82734) | Yes, to work around ODRS flakiness. :( |
discover/qml/UpdatesPage.qml | ||
---|---|---|
39 ↗ | (On Diff #82734) | "Update Issue" |
discover/qml/UpdatesPage.qml | ||
---|---|---|
39 ↗ | (On Diff #82734) | Oops, thanks. Fixed in 11cf0dc694f92551f75617b664cd3e7e49e98df8. |