Refactor: simplify NoteContent
ClosedPublic
Actions

Authored by iasensio on May 12 2020, 5:33 PM.

Details

Reviewers

alex
ognarb

Commits

R1050:80c68df9c9dc: Refactor: simplify NoteContent

Summary

Small refactor to reduce the size of NoteContent class

Move cssColorsName() to Tools, and also use a simpler QHash
Move loadNode() to NoteFactory

Test Plan

It works just the same

Repository

R1050 BasKet

Branch

notecontent

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26803
Build 26821: arc lint + arc unit

iasensio requested review of this revision.May 12 2020, 5:33 PM

iasensio created this revision.

src/notefactory.cpp
1047	While at it you should force braces to the if statements

This revision is now accepted and ready to land.May 12 2020, 7:07 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82680	8388390		May 12 2020, 5:33 PM	★	★
Diff 2	82686	8388390	- Add brackets	May 12 2020, 6:49 PM	★	★
Diff 3	82691	8388390	R1050:80c68df9c9dc4763692b274ee0f33bb6f70fc59b	May 12 2020, 7:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
16c4c883870d	86ce6558a8ef	bb028c898185	Ismael Asensio	Add brackets	May 12 2020, 6:48 PM
bb028c898185	c77feb2d96c5	afb16b46827f	Ismael Asensio	Refactor: simplify NoteContent (Show More…)	May 1 2020, 8:13 PM
afb16b46827f	15aa4ca977ad	8388390c8f83	Ismael Asensio	Move cssColorsName() to Tools	May 1 2020, 7:57 PM