Differential D29680

Fix modified line marker in kate minimap
ClosedPublic
Actions

Authored by davidedmundson on May 12 2020, 2:39 PM.

Details

Reviewers
sars
Group Reviewers
Kate
Commits
R39:f2b0dcdefea7: Fix modified line marker in kate minimap
Summary

Our pixmap is the size of the number of lines in the document. When
rendering the pixel for the modified marker we want to take a ratio of
currentline to lines in the pixmap.

The height of the groove isn't relevant.

Test Plan

Create a 10000 line empty document
Added some line in the middle
New line and orange dot appeared in the same place

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.May 12 2020, 2:39 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMay 12 2020, 2:39 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
davidedmundson requested review of this revision.May 12 2020, 2:39 PM
davidedmundson added a comment.May 12 2020, 2:40 PM

What about ktexteditor?

ngraham added a comment.May 12 2020, 2:41 PM

Ah right, that's still here.

sars accepted this revision.May 12 2020, 3:43 PM
sars added a subscriber: sars.

Thanks for the patch! I had not noticed the problem before :)

This revision is now accepted and ready to land.May 12 2020, 3:43 PM
Closed by commit R39:f2b0dcdefea7: Fix modified line marker in kate minimap (authored by davidedmundson). · Explain WhyMay 13 2020, 10:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateviewhelpers.cpp (9 lines)

Diff 82717

View Options

src/view/kateviewhelpers.cpp

Loading...