Add ability to configure volume step percentage in KMix UI
ClosedPublic

Authored by kurmikon on Mon, May 11, 5:43 PM.

Details

Summary

Kmix users are requesting this feature from years.

https://forum.kde.org/viewtopic.php?f=19&t=92925
https://www.reddit.com/r/kde/comments/45orry/how_can_you_change_the_volume_incrementdecrement/d06h78o/?utm_source=share&utm_medium=web2x

It was added inside the text config, but Plasma is a graphical desktop environment, so why not adding it inside gui config also?

Test Plan

Added a label and a spinbox.

If accepted, I will translate in my language.

Diff Detail

Repository
R345 KMix
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kurmikon requested review of this revision.Mon, May 11, 5:43 PM
kurmikon created this revision.
kurmikon added a subscriber: marten.
marten requested changes to this revision.Wed, May 13, 1:53 PM

Happy for there to be a GUI for the volume step. It doesn't work everywhere (e.g. it should also apply to clicks on the the system tray volume slider), and it would be nice if a restart of KMix was not required, but those can be fixed later. Please see inline comments.

core/GlobalConfig.cpp
34

Consistent indentation

core/GlobalConfig.h
45

Consistent indentation

gui/kmixprefdlg.cpp
212

Could the volume step widget be moved to below the volumeFeedbackWarning message, so that if the message is shown it does not give the impression that the volume step only applies to PulseAudio.

242

"... for the Volume Step and..."

gui/kmixprefdlg.h
114

Consistent indentation

This revision now requires changes to proceed.Wed, May 13, 1:53 PM

I will check it out when have time.

For click on the volume slider I will see if some adjustment can be done. Maybe it can be discussed in separate revision. This was intended to expose only the VolumePercentageStep setting (already present in the code and text config) inside the UI.

For applying the changes without restarting, with my knowledge I'm afraid to be not able to do anything.

kurmikon updated this revision to Diff 82802.Wed, May 13, 10:57 PM
kurmikon marked 5 inline comments as done.

Corrected indentation (I was seeing it good, but atom fills 4 spaces by default while original code used tabs).

Moved spinbox below volume feedback warning.

Maybe in another revision I'll check slider steps.

marten accepted this revision.Thu, May 14, 9:09 AM
This revision is now accepted and ready to land.Thu, May 14, 9:09 AM

@kurmikon: do you have commit access?

@kurmikon: do you have commit access?

No, I don't think so.

This revision was automatically updated to reflect the committed changes.