kurmikon (Giusy Margarita)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 30 2020, 2:57 PM (4 w, 6 d)
Availability
Available

Recent Activity

Sun, May 24

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

@ngraham is there an admin that can review this or should I abandon and make a MR on gitlab?

Sun, May 24, 4:58 PM · Plasma
kurmikon abandoned D29827: Give users the ability to disable the microphone indicator.

https://invent.kde.org/plasma/plasma-pa/-/merge_requests/2

Sun, May 24, 4:53 PM · Plasma

Sat, May 23

kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just now enforced before patch submission, rather than afterwards.

Sat, May 23, 7:39 AM · Plasma

Fri, May 22

kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

You are being rejected because those commits were made using a name that appears to just be a first name - you will need to amend your user.name in your Git configuration and amend the commits accordingly

Fri, May 22, 11:58 PM · Plasma
kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

You need to push to your fork of the plasma-pa repo, not the main location. git push fork should do it if you've set up your fork with the name fork as described in https://community.kde.org/Infrastructure/GitLab#Add_the_fork_to_your_source_checkout

Fri, May 22, 11:13 PM · Plasma
kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

@ngraham I'm following instructions, but push is rejected:

Fri, May 22, 9:07 PM · Plasma
kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

What email? Huh?

Fri, May 22, 8:34 PM · Plasma
kurmikon added a comment to D29827: Give users the ability to disable the microphone indicator.

@ngraham I'm sending the email, but the system reject the request.

Fri, May 22, 7:38 PM · Plasma
kurmikon requested review of D29827: Give users the ability to disable the microphone indicator.
Fri, May 22, 7:16 PM · Plasma

Wed, May 20

kurmikon added a comment to D29663: Add ability to configure volume step percentage in KMix UI.

@kurmikon: do you have commit access?

Wed, May 20, 9:40 AM

Fri, May 15

kurmikon updated the diff for D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Diff updated to a better version. So, I'm explaining what happens here.

Fri, May 15, 5:54 PM · Plasma

Thu, May 14

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using bindings properly. So you'll have to manually set both anywhere the slider's value is currently set, and read the value of both anywhere the slider's value is read.

Thu, May 14, 10:27 PM · Plasma
kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Actually sorry, I won't get to that refactor soon so I don't want to block your work.

Is this reviewable in its current state?

Thu, May 14, 10:04 PM · Plasma

Wed, May 13

kurmikon updated the diff for D29663: Add ability to configure volume step percentage in KMix UI.

Corrected indentation (I was seeing it good, but atom fills 4 spaces by default while original code used tabs).

Wed, May 13, 10:57 PM
kurmikon added a comment to D29663: Add ability to configure volume step percentage in KMix UI.

I will check it out when have time.

Wed, May 13, 2:25 PM

Tue, May 12

kurmikon added a reviewer for D29663: Add ability to configure volume step percentage in KMix UI: VDG.
Tue, May 12, 4:49 PM
kurmikon added a comment to D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.

Got confirmation from @davidedmundson that this is okay. Can you provide an email address so I can land your patch with correct git authorship information?

Tue, May 12, 4:37 PM · Plasma
kurmikon added a comment to D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.

@ngraham No reply after one week. I think this can be merged.

Tue, May 12, 10:01 AM · Plasma
kurmikon added a reviewer for D29663: Add ability to configure volume step percentage in KMix UI: Plasma.
Tue, May 12, 9:58 AM

Mon, May 11

kurmikon requested review of D29663: Add ability to configure volume step percentage in KMix UI.
Mon, May 11, 5:43 PM

Fri, May 8

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a few days until that's done, it might make your patch a lot simpler.

Fri, May 8, 9:57 PM · Plasma
kurmikon updated the diff for D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

So I worked on this.

Fri, May 8, 9:34 PM · Plasma

Tue, May 5

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

I like @ndavis's idea of using a slider and a spinbox. The slider can be used for coarse adjustment, while the spinbox can be used for fine-tuning and have a very fine step size. I think that would work.

[-1, 1] range of values?

Tue, May 5, 7:00 PM · Plasma
kurmikon updated the diff for D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.

Removed stepsize property, default value 1.

Tue, May 5, 3:48 PM · Plasma

May 5 2020

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

I had a look at the documentation for libinput pointer acceleration (https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html). For anyone following this conversation:

  • 0 is the default
  • when greater than 0, acceleration starts sooner and pointer movement increases by larger factors
  • when less than 0, acceleration starts later and pointer movement increases by smaller factors until pointer movement does not increase with mouse movement speed. The point where that happens is somewhere in the range of greater than -0.75 and less than -0.5.
May 5 2020, 10:12 AM · Plasma
kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The value displayed to the user must make some sense or explained with context. In this case, perhaps a percentage would work, with the default value being "100%", and the max and min values displaying 50% and 200%, or something, or whatever the scale actually is.

Didn't we solve this already with Slider + Spinbox in the Display Configuration KCM?

May 5 2020, 7:46 AM · Plasma
kurmikon added a comment to D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.

Maybe we went too far in the direction of efficiency at the expense of familiarity, because the 24px step size suggests inaccurately that intermediate values can't be entered?

May 5 2020, 7:33 AM · Plasma

May 4 2020

kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here.

May 4 2020, 11:22 PM · Plasma
kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Another solution. Spinbox 0% to 100%. -1 is 0% and 1 is 100%. Libinput default 0 will set 50%.

May 4 2020, 11:07 PM · Plasma
kurmikon added a comment to D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.

That doesn't explain why we're changing the step size.

No-one wants to click the up arrow 100 times.

May 4 2020, 10:14 PM · Plasma
kurmikon requested review of D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig.
May 4 2020, 9:49 PM · Plasma
kurmikon abandoned D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options.

No changes needed.

May 4 2020, 8:03 PM · Plasma
kurmikon added a comment to D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options.

How does subpixel hinting work without anti-aliasing?

May 4 2020, 8:01 PM · Plasma
kurmikon added a comment to D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The value displayed to the user must make some sense or explained with context.

May 4 2020, 7:20 PM · Plasma
kurmikon updated the summary of D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options.
May 4 2020, 5:39 PM · Plasma
kurmikon requested review of D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options.
May 4 2020, 5:19 PM · Plasma
kurmikon added a comment to D29312: Change microphoneindicator for reporting audio monitors.

Pulseaudio is an abstraction layer over alsa.

May 4 2020, 10:56 AM · Plasma
kurmikon added a comment to D29312: Change microphoneindicator for reporting audio monitors.
In D29312#662773, @mart wrote:

i think i would prefer a somewhat inaccurate message, rather than an obscuretecnicism which is technically accurate (

May 4 2020, 10:05 AM · Plasma
kurmikon updated the diff for D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.

The spinbox would be a better solution.

May 4 2020, 8:38 AM · Plasma

May 2 2020

kurmikon requested review of D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI.
May 2 2020, 7:47 PM · Plasma

May 1 2020

kurmikon added a comment to D29312: Change microphoneindicator for reporting audio monitors.

@nicolasfella if an application is recording directly from an input device (a simple microphone), your hint would be the solution: we should check and exclude sink source monitors.

May 1 2020, 12:09 AM · Plasma

Apr 30 2020

kurmikon added a comment to D29312: Change microphoneindicator for reporting audio monitors.

but due to a lack in qt libraries

Can you elaborate on this? What is Qt lacking?

I'm not an expert, so I don't really know. Reading the bug report, there's no way to discern input devices from monitor sinks. So if you want to report applications that are using a microphone, you end up showing applications like PuseEffects that create a monitor sink. Those applications can use a microphone but in most cases don't, because PulseEffects is mostly used to apply effects to output streams (but need to record those streams effectively).

Qt is not really involved in this. What matters is what libpulse offers, and it seems to me that we can check whether a sink is a monitor (https://freedesktop.org/software/pulseaudio/doxygen/structpa__source__info.html#a5e304b796ce71c7fa54e5a88f3333630). One would need to add a method isMonitor to Sink that reads this information and then we can not show the indicator when it's a monitor

Apr 30 2020, 7:57 PM · Plasma
kurmikon added a comment to D29312: Change microphoneindicator for reporting audio monitors.

but due to a lack in qt libraries

Can you elaborate on this? What is Qt lacking?

Apr 30 2020, 7:43 PM · Plasma
kurmikon requested review of D29312: Change microphoneindicator for reporting audio monitors.
Apr 30 2020, 6:36 PM · Plasma