[applets/systemtray] Show base icon when AttentionIcon not set

Authored by kmaterka on May 11 2020, 4:07 PM.

Description

[applets/systemtray] Show base icon when AttentionIcon not set

Summary:
If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.

Test Plan:

  • Set NeedsAttention as a status and with no Attention Icon
  • Base Icon should render correctly

Reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson, mart

Reviewed By: Plasma: Workspaces, Plasma, mart

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D29544

Details

Committed
kmaterkaMay 11 2020, 5:26 PM
Reviewer
Plasma: Workspaces
Differential Revision
D29544: [applets/systemtray] Show base icon when AttentionIcon not set
Parents
R120:65f06786f600: [applets/icon] Remove icon from tooltip
Branches
Unknown
Tags
Unknown