Differential D29570

Fix some alignments
ClosedPublic
Actions

Authored by niccolove on May 9 2020, 6:12 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Commits
R120:de52cb8944e8: Fix some alignments
Summary

This fixes some wrong alignments

Test Plan

After:



Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.May 9 2020, 6:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2020, 6:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.May 9 2020, 6:12 PM
niccolove edited the test plan for this revision. (Show Details)May 9 2020, 6:13 PM
niccolove added reviewers: VDG, Plasma.

For some reason, the heading is still one or two pixels off... still, much better than before

ndavis added a subscriber: ndavis.May 10 2020, 11:44 AM
ndavis added inline comments.
applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
34 ↗(On Diff #82389)

How does this affect RTL layouts?

ngraham accepted this revision.May 11 2020, 12:08 AM
This revision is now accepted and ready to land.May 11 2020, 12:08 AM
niccolove added inline comments.May 11 2020, 12:54 PM
applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
34 ↗(On Diff #82389)

It does look a bit too close on the right border in LTS. I guess I should add a rightMargin here?

ngraham added inline comments.May 11 2020, 4:55 PM
applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
34 ↗(On Diff #82389)

Noah's point was that this doesn't automatically reverse itself due to a known Qt bug. However David recently submitted a patch to fix it, so I think we should stop manually working around it, which means this is fine as it is.

Closed by commit R120:de52cb8944e8: Fix some alignments (authored by niccolove). · Explain WhyMay 12 2020, 7:15 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 82631

View Options

applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

Loading...