src/gui/openurljob.cpp
393	missing space after '='
594	That one was on purpose. I find this version less readable, mixing a test and an actual action (with error handling).
src/gui/openurljob.h
114	I think I used the sentence in the two LauncherJobs, feel free to make the same change here.

ahmadsamir marked 2 inline comments as done.May 8 2020, 4:30 PM

ahmadsamir added inline comments.

src/gui/openurljob.cpp
594	Fair point.

Address comments

This revision is now accepted and ready to land.May 8 2020, 5:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/gui/openurljob.h (16 lines)
M			src/gui/openurljob.cpp (36 lines)
M			src/gui/openurljobhandlerinterface.h (10 lines)
M			src/widgets/kdesktopfileactions.cpp (1 line)
M			src/widgets/kopenwithdialog.cpp (7 lines)
M			src/widgets/krun.cpp (2 lines)
M			src/widgets/widgetsopenurljobhandler.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82260	006748d		May 8 2020, 11:56 AM	★	★
Diff 2	82286	de796dc	Address comments	May 8 2020, 4:31 PM	★	★
Diff 3	82304	cb89bab	R241:1b9b239eb262521e4ee5014d3ca79debebf7b1f6	May 8 2020, 6:25 PM	★	★