Support LEDs in Xkb and libinput
ClosedPublic
Actions

Authored by graesslin on Oct 5 2016, 9:53 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:4c7752c965ab: Support LEDs in Xkb and libinput

Summary

The Xkb implementation starts to track the state of the LEDs in the
keymap and emits a signal whenever the LEDs change. This signal is
connected to a method in LibInput::Connection which updates the led
state on all devices and uses it to init the state of the led when a new
device gets connected.

BUG: 369214
FIXED-IN: 5.8.1

Test Plan

Connected a keyboard with LEDs and enabled NumLock and ScrollLock.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 7112.Oct 5 2016, 9:53 AM

graesslin retitled this revision from to Support LEDs in Xkb and libinput.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 5 2016, 9:53 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

If that goes through xkb, does that honor the "Miscellaneous compatibility options → Numeric keyboard keys always enter digits" in keyboard settings? I hate that stupid numlock LED so I use that option to turn the light off while still having numpad enabled.

In D2943#54642, @broulik wrote:

If that goes through xkb, does that honor the "Miscellaneous compatibility options → Numeric keyboard keys always enter digits" in keyboard settings? I hate that stupid numlock LED so I use that option to turn the light off while still having numpad enabled.

If you enabled that through the keyboard configuration module: yes, all those options are honored.