This differential fixes the regression on the user-customized settings file "kstarsui.rc", which was wrongly replaced with the default UI settings file from the resources.
This was done to display UI icons and menus properly in "kstars_ui_tests", but the regression is that any user-customized settings, stored in a local "kstarsui.rc" are not considered anymore.
Details
Details
- Reviewers
mutlaqja murveit - Group Reviewers
KStars - Commits
- R321:01132e09ac44: Let UI tests customize the UI settings file.
Execute "kstars" and check user settings such as keyboard shortcuts are properly enabled.
Execute "kstars_ui_tests" and check icons and menus are properly displayed in the user interface.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kstars/kstarsinit.cpp | ||
|---|---|---|
| 135 | FWIW, I would have preferred this to be either in the header or at the top of the file, just to make the constant more visible, but I don't know if we have a standard on that. In any event, I'm certainly OK with this this also proceeding as is and being merged into the codebase. | |