Differential D2932

Move availableScreenRect/Region up to AppletInterface.
ClosedPublic
Actions

Authored by hein on Oct 4 2016, 12:34 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:89a3e34bd2aa: Move availableScreenRect/Region up to AppletInterface.
Summary

Tested with Folder View and Simple Menu, both use cases (desktop
containment margins, strut-aware dialog placement) addressed.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 7084.Oct 4 2016, 12:34 PM
hein retitled this revision from to Move availableScreenRect/Region up to AppletInterface..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, mart.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2016, 12:34 PM
mart accepted this revision.Oct 4 2016, 12:37 PM
mart edited edge metadata.
mart added inline comments.
src/scriptengines/qml/plasmoid/appletinterface.cpp
663

even if will never likely happen, just for completenesss, adding a check on corona existence here?

669

so could be removed from here

This revision is now accepted and ready to land.Oct 4 2016, 12:37 PM
lbeltrame added a subscriber: lbeltrame.Oct 5 2016, 12:30 PM

This breaks Folder View in a spectacular way: icons overflow out of the applet, and even the title is displayed out of the frame. In some situations I've also seen icons "dancing" continuously (but always overflowing).

Reverting this commit fixes the issue completely.

hein added a comment.Oct 6 2016, 2:02 AM

Luca, can you give me more details? Which use case of Folder View, containment, desktop widget, panel widget? Screenshot? Multiscreen, single screen? I tested the FV/Desktop/single case and it's fine here.

lbeltrame added a comment.Oct 6 2016, 4:53 AM

I've seen this on both multi and single screen. FV placed on the desktop, BTW. Screenshot coming up soon (because I run with the patch reverted).

lbeltrame added a comment.EditedOct 6 2016, 4:55 AM

And this is a screenshot.

EDIT: For completeness sake, I'm running Qt 5.7 from branch, so something close to 5.7.1 (not yet out).

hein closed this revision.Feb 10 2017, 11:29 AM

Forgot to close.

Revision Contents
Changeset List

Diff 7084

View Options

src/scriptengines/qml/plasmoid/appletinterface.h

Loading...
View Options

src/scriptengines/qml/plasmoid/appletinterface.cpp

Loading...
View Options

src/scriptengines/qml/plasmoid/containmentinterface.h

Loading...
View Options

src/scriptengines/qml/plasmoid/containmentinterface.cpp

Loading...