Differential D29314

[PlasmaCore.IconItem] Regression: fix crash on source change
ClosedPublic
Actions

Authored by kmaterka on Apr 30 2020, 8:07 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
Frameworks
Commits
R242:4b0d4c4bdaed: [PlasmaCore.IconItem] Regression: fix crash on source change
Summary

When SvgSource is changed, old one is deleted. Connections are not automatically disconnected.
This change disconnects connections and fixes regression introduced in D28470.

BUG: 420801
FIXED-IN: 5.70

Test Plan

STEPS TO REPRODUCE

  1. click on mute button for a device
  2. click on the desktop to collapse the applet

OBSERVED RESULT
crash in step 1 and in the rare case it doesn't crash it crash in step 2
EXPECTED RESULT
don't crash

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Apr 30 2020, 8:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 30 2020, 8:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kmaterka requested review of this revision.Apr 30 2020, 8:07 PM
kmaterka edited the summary of this revision. (Show Details)Apr 30 2020, 8:08 PM
kmaterka edited the test plan for this revision. (Show Details)
kmaterka added a reviewer: davidedmundson.
kmaterka edited the summary of this revision. (Show Details)
ngraham accepted this revision.Apr 30 2020, 8:12 PM
ngraham edited the summary of this revision. (Show Details)

Nice. This also fixes another crash I was seeing with the ExpandableListItem applets.

This revision is now accepted and ready to land.Apr 30 2020, 8:14 PM
Closed by commit R242:4b0d4c4bdaed: [PlasmaCore.IconItem] Regression: fix crash on source change (authored by kmaterka). · Explain WhyApr 30 2020, 8:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81631

View Options

src/declarativeimports/core/iconitem.cpp

Loading...