| davidedmundson |
| Plasma |
Instead of using KF5 which is wrong since KSysGuard isn't part of
frameworks.
This needs a follow up patch to the ksysguard repo to make it use the new
namespace.
For backward compatibility, a KF5SysGuardConfig file is still installed that
aliases the new targets, but mentions they are deprecated.
Still builds
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
With this change, plasma-workspace fails to build on my system (Neon User, kdesrc-build)
Error message:
CMake Warning at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:27 (message): The KF5:: namespace for KSysGuard targets is deprecated. Please use KSysGuard as namespace. Call Stack (most recent call first): /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) CMake Error at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34 (add_library): add_library cannot create ALIAS target "KF5::SysGuard" because target "KSysGuard::SysGuard" is IMPORTED. Call Stack (most recent call first): /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (add_sysguard_target) /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) CMake Error at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34 (add_library): add_library cannot create ALIAS target "KF5::ProcessCore" because target "KSysGuard::ProcessCore" is IMPORTED. Call Stack (most recent call first): /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:38 (add_sysguard_target) /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) CMake Error at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34 (add_library): add_library cannot create ALIAS target "KF5::ProcessUi" because target "KSysGuard::ProcessUi" is IMPORTED. Call Stack (most recent call first): /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:39 (add_sysguard_target) /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) CMake Error at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34 (add_library): add_library cannot create ALIAS target "KF5::LsofUi" because target "KSysGuard::LsofUi" is IMPORTED. Call Stack (most recent call first): /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:40 (add_sysguard_target) /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) CMake Error at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:34 (add_library): add_library cannot create ALIAS target "KF5::SignalPlotter" because target "KSysGuard::SignalPlotter" is IMPORTED. Call Stack (most recent call first): /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:41 (add_sysguard_target) /home/konrad/kde/usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package) CMakeLists.txt:55 (find_package) -- Found KF5SysGuard: /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake
Which version of CMake are you using? I needed to promote the imported KSysGuard targets to "global" using set_target_property. Without that, I saw similar errors. The IMPORTED_GLOBAL property was added in CMake 3.11.