Differential D29285

KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()
ClosedPublic
Actions

Authored by crossi on Apr 29 2020, 5:38 PM.

Details

Reviewers
bport
broulik
Group Reviewers
Plasma
Commits
R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()
R119:fdfb48786ed5: Merge branch 'Plasma/5.18'
Summary

Changing the icon size should emits KIconloader::iconLoaderSettingsChanged as well

BUG: 420577
FIXED-IN: 5.18.5

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Apr 29 2020, 5:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2020, 5:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Apr 29 2020, 5:38 PM
crossi edited the summary of this revision. (Show Details)Apr 29 2020, 5:39 PM
broulik accepted this revision.Apr 30 2020, 6:49 AM
broulik added a subscriber: broulik.

Thanks

Can this go into 5.18?

kcms/icons/main.cpp
147

I think this check isn't necessary

150

You can also do index.data(role)

304

Isn't this redundant? i.e. doesn't emitChange emit do exactly this?

This revision is now accepted and ready to land.Apr 30 2020, 6:49 AM
crossi added a comment.Apr 30 2020, 7:22 AM
In D29285#660158, @broulik wrote:

Can this go into 5.18?

Sure.

kcms/icons/main.cpp
304

This one sends a notifyChange signal.

KIconLoader::emitChange() sends a iconChanged() signal.

From KIconLoader :

QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KIconLoader"), QStringLiteral("org.kde.KIconLoader"), QStringLiteral("iconChanged"));
crossi updated this revision to Diff 81567.Apr 30 2020, 7:36 AM

consider Kai's comments

crossi edited the summary of this revision. (Show Details)Apr 30 2020, 7:49 AM
bport accepted this revision.Apr 30 2020, 7:51 AM
Closed by commit R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader() (authored by crossi). · Explain WhyApr 30 2020, 7:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81569

View Options

kcms/icons/iconsizecategorymodel.h

Loading...
View Options

kcms/icons/iconsizecategorymodel.cpp

Loading...
View Options

kcms/icons/main.cpp

Loading...