In KWin, we need to know when a sub-surface becomes mapped or unmapped
so we can generate or filter out window quads for the sub-surface.
Details
Details
- Reviewers
davidedmundson apol - Group Reviewers
KWin
Diff Detail
Diff Detail
- Repository
- R127 KWayland
- Branch
- introduce-mapped-signal
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 26046 Build 26064: arc lint + arc unit
Comment Actions
+1
| src/server/surface_interface.cpp | ||
|---|---|---|
| 333 | Using != would probably be more readable and accurate (we're don't need it to be bitwise, we're assuming bool changes it to 00001 or 00000). | |
Comment Actions
Check whether the attached buffer flip-flopped between non-null and null only when bufferChanged is true.
| src/server/surface_interface.cpp | ||
|---|---|---|
| 333 | We can't use != because mapped() will be emitted each time a new buffer is attached to the surface. | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 333 | I don't understand, ^ and != are logically equivalent, ^ is the bitwise counterpart. Am I missing something? | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 333 | Oh, I thought you suggested to do source->buffer != target->buffer. | |