Differential D29251

API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug
ClosedPublic
Actions

Authored by kossebau on Apr 28 2020, 11:49 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R244:9e76c0bbdec4: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug
Summary

See https://github.com/doxygen/doxygen/issues/7734

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 28 2020, 11:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 28 2020, 11:49 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 28 2020, 11:49 AM
kossebau added a comment.Apr 28 2020, 11:50 AM

Given unsigned long is 32 bit on some systems and 64 bit on others, perhaps this should also get a KF6 TODO to use a different type. 32 bit might be enough in general for the percent value, no?

dfaure accepted this revision.Apr 28 2020, 7:46 PM

Yes indeed, for sure "int" would be enough.

This revision is now accepted and ready to land.Apr 28 2020, 7:46 PM
Closed by commit R244:9e76c0bbdec4: API dox: use ulong typedef with Q_PROPERTY(percent) to avoid doxygen bug (authored by kossebau). · Explain WhyApr 28 2020, 7:55 PM
This revision was automatically updated to reflect the committed changes.
kossebau added a comment.Apr 28 2020, 8:19 PM
In D29251#659376, @dfaure wrote:

Yes indeed, for sure "int" would be enough.

So okay if I add a "// KF6 TODO: make int" behind the Q_PROPERTY(percent) at the end of the line?

Revision Contents
Changeset List

PathPackages
Msrc/lib/jobs/kjob.h (2 lines)

Diff 81473

View Options

src/lib/jobs/kjob.h

Loading...