D361740 - Disable warning "The document requested to be launched in presentation mode" on document reload
Needs ReviewPublic

Authored by ictwod on Apr 28 2020, 4:26 AM.

Details

Reviewers
aacid
Summary

Further description here:

https://bugs.kde.org/show_bug.cgi?id=361740

When using Okular as previewer in PDFTex workflow, preparing beamer slides, the following usability hell occurred:

  • LaTex/Beamer slides should be compiled to PDF with metadata "StartFullScreen"
  • But while editing, on every PDF change/and reload, the user gets a modal popup "The document requested to be launched in presentation mode." "Do you want to allow it?"

(See part.cpp)

  • This makes typical Slide/LaTeX/Beamer editing workflow completely unusable.

FIX:

  • Completely disable this warning on reload of the changed document.
Test Plan

  1. Download and unzip test materials

First Test:

  1. Run demo.sh
  2. Open generated demo.pdf in Okular
  3. Click 'Deny Request' on full-screen prompt
  4. Reload pdf by pressing F5 or File>Reload
  5. demo.pdf should reload without full-screen prompt showing again

Second Test:

  1. Run demo.sh
  2. Open generated demo.pdf in Okular
  3. Click 'Deny Request' on full-screen prompt
  4. Keep demo.pdf open in Okular and run demo.sh again
  5. demo.pdf should automatically reload without full-screen prompt showing again

Diff Detail

Repository
R223 Okular
Lint
Lint Skipped
Unit
Unit Tests Skipped
ictwod created this revision.Apr 28 2020, 4:26 AM
Restricted Application added a project: Okular. · View Herald TranscriptApr 28 2020, 4:26 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
ictwod requested review of this revision.Apr 28 2020, 4:26 AM

Thanks for the patch! Okular uses GitLab now. Can you re-submit this as a Merge Request at https://invent.kde.org/kde/okular/-/merge_requests/?

Documentation can be found at https://community.kde.org/Infrastructure/GitLab