Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob
ClosedPublic
Actions

Authored by dfaure on Apr 26 2020, 2:48 PM.

Details

Reviewers

ahmadsamir
broulik

Commits

Test Plan

New unittest passes

Repository

R241 KIO

Branch

2020_04_invalid_service

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25952
Build 25970: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

dfaure requested review of this revision.Apr 26 2020, 2:48 PM

remove redundant line

fix wrong "Test" in commit log

Otherwise makes sense.

src/gui/kprocessrunner.cpp
55	IMHO, the word "entry" here is confusing, the first thing that comes to mind is that an entry (i.e. a line) in the file is invalid.

src/gui/kprocessrunner.cpp
55	I see what you're saying. It's the name of the spec, though. https://specifications.freedesktop.org/desktop-entry-spec/latest/ Each file is an "entry for the desktop", I guess.

ahmadsamir added inline comments.

src/gui/kprocessrunner.cpp
55	Well, what can we do... that ship has sailed.

This revision is now accepted and ready to land.Apr 27 2020, 9:25 PM

			Path	Packages
M			autotests/applicationlauncherjobtest.h (2 lines)
M			autotests/applicationlauncherjobtest.cpp (21 lines)
M			src/gui/kprocessrunner.cpp (7 lines)
M			src/widgets/kdesktopfileactions.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81249	006fd05		Apr 26 2020, 2:48 PM	★	★
Diff 2	81250	006fd05	remove redundant line	Apr 26 2020, 2:48 PM	★	★
Diff 3	81281	006fd05	fix wrong "Test" in commit log	Apr 26 2020, 8:01 PM	★	★