Differential D29145

Rules kcm: Use new property ComboBox.currentValue
ClosedPublic
Actions

Authored by iasensio on Apr 23 2020, 9:37 PM.

Details

Reviewers
ngraham
zzag
Group Reviewers
KWin
Commits
R108:a158d3cbd3f9: Rules kcm: Use new property ComboBox.currentValue
Summary

Use the properties valueRole and currentValue, introduced in Qt5.14 for QQC2.ComboBox

This didn't work before due to QQC2 version being mis-detected at build time, so the code mocked an internal currentValue property.

After D28859, it is now required to fix:

"file:///home/nate/kde/usr/share/kpackage/kcms/kcm_kwinrules/contents/ui/RulesEditor.qml" 
"Error loading QML file.\n42: Type RuleItemDelegate unavailable\n68: Type OptionsComboBox unavailable\n35: Cannot override FINAL property\n"
QCoreApplication::postEvent: Unexpected null receiver
Test Plan

Try to edit a rule or add a new one.
The rule editor page shows.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Apr 23 2020, 9:37 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 23 2020, 9:37 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
iasensio requested review of this revision.Apr 23 2020, 9:37 PM
ngraham accepted this revision.Apr 23 2020, 9:51 PM

Qt 5.14 is the dependency for Plasma 5.19, so this is fine.

This revision is now accepted and ready to land.Apr 23 2020, 9:51 PM
iasensio edited the summary of this revision. (Show Details)Apr 23 2020, 9:57 PM
iasensio edited the summary of this revision. (Show Details)Apr 23 2020, 10:17 PM
iasensio edited the summary of this revision. (Show Details)Apr 23 2020, 10:20 PM
zzag accepted this revision.Apr 24 2020, 5:36 AM
Closed by commit R108:a158d3cbd3f9: Rules kcm: Use new property ComboBox.currentValue (authored by iasensio). · Explain WhyApr 24 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81094

View Options

kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml

Loading...