[kwinrules] Avoid shadowing FINAL property
AbandonedPublic
Actions

Authored by davidedmundson on Apr 25 2020, 4:57 PM.

Details

Reviewers

None

Group Reviewers

KWin

Summary

In Qt5.15 currentValue is a FINAL property meaning that shadowing it is
a fatal eror.

Also this patch slightly more gracefully handles QML errors. Asserting
instead of crash.

Test Plan

Used against Qt5.15 git compiled qqc2-desktop-style

Repository

R108 KWin

Branch

davidedmundson/wl_temp

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25885
Build 25903: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptApr 25 2020, 4:57 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Apr 25 2020, 4:57 PM

Hi @davidedmundson, with D29145 all of the offending code has been removed, to just use QQC2.ComboBox.currentValue directly.

cool cool

			Path	Packages
M			kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml (4 lines)
M			kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml (2 lines)
M			kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml (2 lines)
M			kcmkwin/kwinrules/rulesdialog.cpp (6 lines)