Make the background of the logout screen darker
AbandonedPublic

Authored by jsalatas on Oct 2 2016, 5:05 PM.

Details

Reviewers
None
Group Reviewers
Plasma: Design
Plasma
Summary

There are cases (based on the active window contents) that the elements of the logout screen aren't readable. Making the background of the logout screen darker seems to fix the problem.

Test Plan

Before

After

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
jsalatas updated this revision to Diff 7038.Oct 2 2016, 5:05 PM
jsalatas retitled this revision from to Make the background of the logout screen darker.
jsalatas updated this object.
jsalatas edited the test plan for this revision. (Show Details)
jsalatas added reviewers: Plasma, Plasma: Design.
jsalatas set the repository for this revision to R120 Plasma Workspace.
jsalatas added a subscriber: apol.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 2 2016, 5:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

There /shoud/ be a blur applied that's not being shown in the original screenshot.

Can I see the output of:
qdbus org.kde.KWin /KWin supportInformation

There is no blur effect (I'm running it in a Virtual Machine with no 3D acceleration).

Here is the output of the qdbus org.kde.KWin /KWin supportInformation command

# qdbus org.kde.KWin /KWin supportInformation
KWin Support Information:
The following information should be used when requesting support on e.g. http://forum.kde.org.
It provides information about the currently running instance, which options are used,
what OpenGL driver and which effects are running.
Please post the information provided underneath this introductory text to a paste bin service
like http://paste.kde.org instead of pasting into support threads.

==========================

Version
=======
KWin version: 5.8.90
Qt Version: 5.7.0
Qt compile version: 5.7.0
XCB compile version: 1.11.1

Operation Mode: X11 only

Build Options
=============
KWIN_BUILD_DECORATIONS: yes
KWIN_BUILD_TABBOX: yes
KWIN_BUILD_ACTIVITIES: yes
HAVE_INPUT: yes
HAVE_DRM: yes
HAVE_GBM: yes
HAVE_X11_XCB: yes
HAVE_EPOXY_GLX: yes
HAVE_WAYLAND_EGL: yes

X11
===
Vendor: The X.Org Foundation
Vendor Release: 11803000
Protocol Version/Revision: 11/0
SHAPE: yes; Version: 0x11
RANDR: yes; Version: 0x14
DAMAGE: yes; Version: 0x11
Composite: yes; Version: 0x4
RENDER: yes; Version: 0xb
XFIXES: yes; Version: 0x50
SYNC: yes; Version: 0x31
GLX: yes; Version: 0x0

Decoration
==========
Plugin: org.kde.breeze
Theme:
Blur: 0
onAllDesktopsAvailable: true
alphaChannelSupported: true
closeOnDoubleClickOnMenu: false
decorationButtonsLeft: 0, 2
decorationButtonsRight: 6, 3, 4, 5
borderSize: 3
gridUnit: 10
font: Noto Sans,10,-1,0,50,0,0,0,0,0
smallSpacing: 2
largeSpacing: 10

Options
=======
focusPolicy: 0
nextFocusPrefersMouse: false
clickRaise: true
autoRaise: false
autoRaiseInterval: 0
delayFocusInterval: 0
shadeHover: false
shadeHoverInterval: 250
separateScreenFocus: false
placement: 4
focusPolicyIsReasonable: true
borderSnapZone: 10
windowSnapZone: 10
centerSnapZone: 0
snapOnlyWhenOverlapping: false
rollOverDesktops: true
focusStealingPreventionLevel: 1
legacyFullscreenSupport: false
operationTitlebarDblClick: 5000
operationMaxButtonLeftClick: 5000
operationMaxButtonMiddleClick: 5015
operationMaxButtonRightClick: 5014
commandActiveTitlebar1: 0
commandActiveTitlebar2: 30
commandActiveTitlebar3: 2
commandInactiveTitlebar1: 4
commandInactiveTitlebar2: 30
commandInactiveTitlebar3: 2
commandWindow1: 7
commandWindow2: 8
commandWindow3: 8
commandWindowWheel: 31
commandAll1: 10
commandAll2: 3
commandAll3: 14
keyCmdAllModKey: 16777251
showGeometryTip: false
condensedTitle: false
electricBorderMaximize: true
electricBorderTiling: true
electricBorderCornerRatio: 0.25
borderlessMaximizedWindows: false
killPingTimeout: 5000
hideUtilityWindowsForInactive: true
inactiveTabsSkipTaskbar: false
autogroupSimilarWindows: false
autogroupInForeground: true
compositingMode: 2
useCompositing: true
compositingInitialized: true
hiddenPreviews: 1
glSmoothScale: 2
colorCorrected: false
xrenderSmoothScale: false
maxFpsInterval: 16666666
refreshRate: 0
vBlankTime: 6000000
glStrictBinding: true
glStrictBindingFollowsDriver: true
glCoreProfile: false
glPreferBufferSwap: 97
glPlatformInterface: 1
windowsBlockCompositing: true

Screen Edges
============
desktopSwitching: false
desktopSwitchingMovingClients: false
cursorPushBackDistance: 1x1
timeThreshold: 150
reActivateThreshold: 350
actionTopLeft: 0
actionTop: 0
actionTopRight: 0
actionRight: 0
actionBottomRight: 0
actionBottom: 0
actionBottomLeft: 0
actionLeft: 0

Screens
=======
Multi-Head: no
Active screen follows mouse: no
Number of Screens: 1

Screen 0:
---------
Name: VGA-1
Geometry: 0,0,1920x950
Refresh Rate: 59.8991


Compositing
===========
Compositing is active
Compositing Type: XRender

Loaded Effects:
---------------
zoom
slidingpopups
kwin4_effect_login
slide
screenshot
kwin4_effect_translucency
kwin4_effect_windowaperture
minimizeanimation
desktopgrid
kwin4_effect_morphingpopups
kwin4_effect_fade
kwin4_effect_maximize
presentwindows
kwin4_effect_dialogparent
highlightwindow
screenedge
kscreen

Currently Active Effects:
-------------------------

Effect Settings:
----------------
zoom:
zoomFactor: 1.2
mousePointer: 0
mouseTracking: 0
enableFocusTracking: false
followFocus: true
focusDelay: 350
moveFactor: 20
targetZoom: 1

slidingpopups:
fadeInTime: 150
fadeOutTime: 250

kwin4_effect_login:

slide:

screenshot:

kwin4_effect_translucency:

kwin4_effect_windowaperture:

minimizeanimation:

desktopgrid:
zoomDuration: 300
border: 10
desktopNameAlignment: 0
layoutMode: 0
customLayoutRows: 2
usePresentWindows: true

kwin4_effect_morphingpopups:

kwin4_effect_fade:

kwin4_effect_maximize:

presentwindows:
layoutMode: 0
showCaptions: true
showIcons: true
doNotCloseWindows: false
ignoreMinimized: false
accuracy: 20
fillGaps: true
fadeDuration: 150
showPanel: false
leftButtonWindow: 1
rightButtonWindow: 2
middleButtonWindow: 0
leftButtonDesktop: 2
middleButtonDesktop: 0
rightButtonDesktop: 0

kwin4_effect_dialogparent:

highlightwindow:

screenedge:

kscreen:

#
mart added a subscriber: mart.Oct 3 2016, 9:52 AM
mart added inline comments.
lookandfeel/contents/logout/Logout.qml
61

making the background darker makes sense.
But you already have a translucent black Rectangle at line 83, no need to add another one, just tweak opacity of that one (no more than ~0.75 tough)

jsalatas updated this revision to Diff 7058.EditedOct 3 2016, 3:07 PM
jsalatas edited the test plan for this revision. (Show Details)

According to mart's suggestion there is already a rectangle, so there is no need to add a new one (the "after" screenshot is also updated to reflect this).

It seems to me that the "best" value for opacity would be 0.8 (having 0.75 or less is still not clear enough)

jsalatas abandoned this revision.Oct 6 2016, 7:12 PM

I just tested it in a normal PC (ie not Virtual Machine) with 3D acceleration and the background is indeed blurred as davidedmundson said.

So I'm abandoning this, as it seems a very minor issue.

apol added a comment.Oct 6 2016, 7:21 PM

FWIW it could still make sense. the text is not super readable sometimes, as it's gray (at least on my system).