Differential D29118

Network Filesharing: Refactor foreach and emit, smaller improvements
ClosedPublic
Actions

Authored by alex on Apr 23 2020, 4:45 AM.

Details

Reviewers

ngraham

Group Reviewers

Dolphin

Commits

R432:41034c763ced: Network Filesharing: Refactor foreach and emit, smaller improvements

Summary

Compile without emit and foreach.
The private variables inside the model are prefixed with _, because
the userList variable shadowed class definition. This should clear things up.

And some better overloads and const qualifiers.

Test Plan

Compiles

Diff Detail

Repository

R432 File Sharing (Samba) integration

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25731
Build 25749: arc lint + arc unit

alex requested review of this revision.Apr 23 2020, 4:45 AM

alex created this revision.

Harbormaster completed remote builds in B25731: Diff 80953.Apr 23 2020, 4:45 AM

ngraham accepted this revision.Apr 23 2020, 5:02 AM

This revision is now accepted and ready to land.Apr 23 2020, 5:02 AM

Closed by commit R432:41034c763ced: Network Filesharing: Refactor foreach and emit, smaller improvements (authored by alex). · Explain WhyApr 23 2020, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (5 lines)
M			samba/filepropertiesplugin/model.h (6 lines)
M			samba/filepropertiesplugin/model.cpp (47 lines)
M			samba/filepropertiesplugin/sambausershareplugin.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80953	bb0c8a4		Apr 23 2020, 4:45 AM	★	★
Diff 2	80956	bb0c8a4	R432:41034c763ced6620020d11d2b11986c5215f6f9c	Apr 23 2020, 5:43 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
eb2c720df3e0	279df8593cbc	bb0c8a4da9df	Alexander Lohnau	Network Filesharing: Refactor foreach and emit, smaller improvements (Show More…)	Apr 22 2020, 8:08 PM