correct vscode icon name
ClosedPublic

Authored by guoyunhe on Apr 22 2020, 6:44 AM.

Details

Summary

com.visualstudio.code.svg and com.visualstudio.code.oss.svg

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Apr 22 2020, 6:44 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 22 2020, 6:44 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
guoyunhe requested review of this revision.Apr 22 2020, 6:44 AM
ngraham added a subscriber: ngraham.

Could the old one still ever be valid ? Should we maybe add a symlink instead of renaming?

guoyunhe added a comment.EditedApr 22 2020, 3:55 PM

The icon was renamed since 2019. commit

Most users should have updated to newer version.

ngraham accepted this revision.Apr 22 2020, 4:24 PM

I suppose anyone using an old version would be on a discrete release distro that wouldn't update breeze icons either. OK, ship it!

This revision is now accepted and ready to land.Apr 22 2020, 4:24 PM
Closed by commit R266:d44aa218457b: correct vscode icon name (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyApr 22 2020, 4:59 PM
This revision was automatically updated to reflect the committed changes.