Differential D29062

Port KToolInvocation::kdeinitExecWait to QProcess
ClosedPublic
Actions

Authored by broulik on Apr 21 2020, 4:28 PM.

Details

Reviewers
davidedmundson
apol
Group Reviewers
Frameworks
Commits
R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to QProcess
Test Plan

Part of T12185
Verified it's calling it and returning with NormalExit and 0 exitcode - didn't actually test whether it worked :D

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 21 2020, 4:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 21 2020, 4:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 21 2020, 4:28 PM
apol accepted this revision.Apr 21 2020, 11:58 PM
apol added a subscriber: apol.
apol added inline comments.
src/kded.cpp
67 ↗(On Diff #80785)

The function has a typo, should be runKConfUpdate, no?

This revision is now accepted and ready to land.Apr 21 2020, 11:58 PM
Closed by commit R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to QProcess (authored by broulik). · Explain WhyApr 23 2020, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kded.cpp (7 lines)

Diff 80973

View Options

src/kded.cpp

Loading...