Differential D2906

test_qthelpplugin: Do not rely on other target creating code from ui file
ClosedPublic
Actions

Authored by kossebau on Oct 1 2016, 1:37 PM.

Details

Reviewers
apol
brauch
kfunk
Commits
R32:c246c9c25063: test_qthelpplugin: Do not rely on other target creating code from ui file
Summary

test_qthelpplugin target uses sources which rely on files created from
ui files, but which are only build as part of the target kdevqthelp.

On parallel builds like on KDE CI it can happen that test_qthelpplugin
is build before kdevqthelp, as there is no dependency between the two.
See e.g. https://build.kde.org/view/Kdevelop/job/kdevelop%205.0%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/146/console

Adding the respective ui files explicitely to the test_qthelpplugin target
solves the issue.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 7024.Oct 1 2016, 1:37 PM
kossebau retitled this revision from to test_qthelpplugin: Do not rely on other target creating code from ui file.
kossebau updated this object.
kossebau added reviewers: brauch, kfunk, apol.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 1 2016, 1:37 PM
kfunk accepted this revision.Oct 3 2016, 3:53 PM
kfunk edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 3:53 PM
Closed by commit R32:c246c9c25063: test_qthelpplugin: Do not rely on other target creating code from ui file (authored by kossebau). · Explain WhyOct 3 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7061

View Options

documentation/qthelp/tests/CMakeLists.txt

Loading...