Move document corner fold to top right in two icons
ClosedPublic

Authored by davidhurka on Apr 20 2020, 9:12 PM.

Details

Summary

This updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203.

gnumeric-link-internal uses Highlight, it had a fixed color before.

document-close uses NegativeText in all versions. The 16px dark version used Text before.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidhurka created this revision.Apr 20 2020, 9:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2020, 9:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidhurka requested review of this revision.Apr 20 2020, 9:12 PM
davidhurka retitled this revision from Move document corner fold to top right in two icons This updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203. gnumeric-link-internal uses ButtonFocus. to Move document corner fold to top right in two icons.Apr 20 2020, 9:14 PM
davidhurka edited the summary of this revision. (Show Details)
davidhurka edited the test plan for this revision. (Show Details)
davidhurka added a reviewer: ndavis.
davidhurka edited the summary of this revision. (Show Details)Apr 20 2020, 9:18 PM
davidhurka updated this revision to Diff 80707.Apr 20 2020, 9:24 PM
  • Use Highlight instead of ButtonFocus, Noah already decided that somewhere else
davidhurka edited the summary of this revision. (Show Details)Apr 20 2020, 9:25 PM
ngraham accepted this revision.Apr 20 2020, 9:44 PM
This revision is now accepted and ready to land.Apr 20 2020, 9:44 PM
ndavis accepted this revision.Apr 20 2020, 9:46 PM

I looked at the other gnumeric icons. Those which are not a symlink use fixed colors, while the linked icons use Highlight. I don’t see the point to use fixed colors.

Is it possible to land this without arc? I can’t get arc running on my current system. :(

If you want this in the next release, you too may land it for me. Otherwise I will land it when I have my own system back, i. e. in a few weeks.

I will change the other gnumeric icons to use Highlight instead of a fixed color later.

You can do a regular old git push if you cherry-pick the commit onto master. I'll land it for you though.

This revision was automatically updated to reflect the committed changes.