Before:
After:
Diff Detail
Diff Detail
- Repository
- R454 Kompare
- Branch
- formlayout
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25544 Build 25562: arc lint + arc unit
Comment Actions
As now and then Kompare user not sure I woudl fancy having less wide input fields for destination & source. I often operate in deep folder levels, the more of the path to see, the better (your example screenshots also already show this). And looking at the After screenshot, it really seems strange that all the screen real estate is not used, instead things are squashed at the top.
Surely the old design was also not that fancy. But it seems more usable to me :) So if you ask me, not to happy about this change.
And then some nitpick comments:
*KDE HIG wants ":" after labels consistently
- while touching i18n strings, please add User Interface Markers context to the calls, to help translators. See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text
- Patch changes more than just switching to QFormLayout,, the commit message might want to reflect that.
- pass QString be const reference
Comment Actions
The after screenshot is also a bit smaller but I see that you mean. I'm not sure how to fix it.
Surely the old design was also not that fancy. But it seems more usable to me :) So if you ask me, not to happy about this change.
And then some nitpick comments:
*KDE HIG wants ":" after labels consistently
- while touching i18n strings, please add User Interface Markers context to the calls, to help translators. See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text
- Patch changes more than just switching to QFormLayout,, the commit message might want to reflect that.
- pass QString be const reference
Thanks I will fix those