Differential D28973

Fix cache directory calculation when adding to trash
ClosedPublic
Actions

Authored by meven on Apr 19 2020, 8:20 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:ff831cb609ea: Fix cache directory calculation when adding to trash
Summary

The directory size was not added to the directory cache size since D24773

Test Plan

Moved a folder to trash.
Its size is visible in
~/.local/share/Trash/directorysizes

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Apr 19 2020, 8:20 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 19 2020, 8:20 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Apr 19 2020, 8:20 AM
dfaure accepted this revision.Apr 19 2020, 9:06 AM

Good catch. I wonder if the unittest could be extended so it would have caught this.

This revision is now accepted and ready to land.Apr 19 2020, 9:06 AM
meven updated this revision to Diff 80534.Apr 19 2020, 12:20 PM

Add test

Closed by commit R241:ff831cb609ea: Fix cache directory calculation when adding to trash (authored by meven). · Explain WhyApr 19 2020, 12:21 PM
This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Apr 19 2020, 12:53 PM

Thanks. >0 is already something :-)

Revision Contents
Changeset List

Diff 80535

View Options

src/ioslaves/trash/tests/testtrash.cpp

Loading...
View Options

src/ioslaves/trash/trashimpl.cpp

Loading...