Differential D2897

Session chooser: Ensure no unnecessary horizontal scroll bar.
ClosedPublic
Actions

Authored by ahartmetz on Sep 30 2016, 5:26 PM.

Details

Reviewers
dhaumann
cullmann
lueck
Summary

There really is no need to resize any but the first columns.
The fancy manual layout was faulty and made the view too large.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
ahartmetz updated this revision to Diff 7009.Sep 30 2016, 5:26 PM
ahartmetz retitled this revision from to Session chooser: Ensure no unnecessary horizontal scroll bar..
ahartmetz updated this object.
ahartmetz edited the test plan for this revision. (Show Details)
ahartmetz set the repository for this revision to R40 Kate.
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptSep 30 2016, 5:26 PM
ahartmetz added a comment.Sep 30 2016, 5:33 PM

Session chooser before:

After:

Probably the width of the vertical scrollbar isn't taken into account in the manual layout code, but in any case, stretching the second row is rather dubious anyway.

dhaumann accepted this revision.Sep 30 2016, 5:40 PM
dhaumann edited edge metadata.

The patch looks good, please commit to master branch.

This revision is now accepted and ready to land.Sep 30 2016, 5:40 PM
cullmann closed this revision.Jan 22 2017, 4:13 PM
cullmann edited edge metadata.

Was commited.

97116ac0a3ac98ce265fe648928988ba68ea4cd1

Session chooser: Ensure no unnecessary horizontal scroll bar.

There really is no need to resize any but the first columns.
The manual layout did not take into account the width of the
vertical scroll bar. This here is much easier than fixing that.

Revision Contents
Changeset List

Diff 7009

View Options

kate/session/katesessionchooser.h

Loading...
View Options

kate/session/katesessionchooser.cpp

Loading...