Include first KDECompilerSettings, so all other included macros pick up cmake policies
ClosedPublic

Authored by kossebau on Sep 30 2016, 4:16 PM.

Details

Summary

From cmake_policy() documentation:
"Functions and macros record policy settings when they are created and use
the pre-record policies when they are invoked."

As KDECompilerSettings sets at least CMP0063, it needs to be included before
all other files which define macros affected by this policy, like ECMAddTests.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 7008.Sep 30 2016, 4:16 PM
kossebau retitled this revision from to Include first KDECompilerSettings, so all other included macros pick up cmake policies.
kossebau updated this object.
kossebau added reviewers: apol, mwolff, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 30 2016, 4:16 PM
apol edited edge metadata.Sep 30 2016, 4:19 PM

Is that a problem somewhere or a theoretical approach?

Indeed incomplete patch description, pardon.

Currently the log of a cmake run on kdevelop checkout is ending with lots of CMake Warnings about Policy CMP0063 not being set, burying the interesting log content. This patch solves that.
kdevplatform already includes KDECompilerSettings as first file, so no issue there.

apol accepted this revision.Sep 30 2016, 6:11 PM
apol edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2016, 6:11 PM
kfunk accepted this revision.Oct 1 2016, 10:01 AM
kfunk edited edge metadata.

-> 5.0 branch

This revision was automatically updated to reflect the committed changes.