Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T12936: solar_system move config to activityConfig multipledata style
Diff Detail
- Repository
- R2 GCompris
- Branch
- solar_aconfig
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25470 Build 25488: arc lint + arc unit
Thank you,
I saw two bugs with the changes:
When starting the activity from the menu, I have the following error: "qrc:/gcompris/src/activities/solar_system/ActivityConfig.qml:66: ReferenceError: items is not defined". And if I changed the configuration before, it is not taken in account.
| src/activities/solar_system/ActivityConfig.qml | ||
|---|---|---|
| 67 | this does not work, when I display numberOfLevel in nextLevel(), it tells it's undefined. | |
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | ||
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | '===', | |
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | Yes, having === is better as it compares the data type should also be same before comparison. I would update it. | |
Comment to be detailed thanks.
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | I don't understand this comment. Could you please explain it in details? Thanks. | |
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | @echarruau Hi, I will try to explain this with an example. Let's take two example
In the first example it would return true, while comparing a string with integer. As the string also gets converted to integer due to type conversion which happens in JavaScript. | |
| src/activities/solar_system/SolarSystem.qml | ||
|---|---|---|
| 79 | Ok for me then, it makes sens. | |