That unused EditPage::openUrl pulled in KIOWidgets with all its dependencies.
This includes KCompletion which implicitly made that KComboBox work.
Remove this and clean up the dependencies.
NetworkManagerQt seems to pull in Qt::Network but doesn't automatically find it.
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma
- Still builds
- Battery critical combo still works
- Run script combo still works
Diff Detail
Diff Detail
- Repository
- R122 Powerdevil
- Lint
Lint Skipped - Unit
Unit Tests Skipped
CMakeLists.txt | ||
---|---|---|
20 | That's not right at least. It should be optional when KF5NetworkManagerQt is found. It looks weird to present at all. |
CMakeLists.txt | ||
---|---|---|
20 | Yes, this looks wrong but I don't understand why I even have to add this manually... NetworkManager-Qt CMake looks for Qt5 Network and it also has it in its PUBLIC link interface. |
Comment Actions
I've noticed I accidentally removed compiling a few things, that also depend on KIO, so maybe not as lean as I hoped